Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement system calls with attribute proc macro #1105

Merged
merged 12 commits into from
Mar 23, 2024

Conversation

mkroening
Copy link
Member

@mkroening mkroening commented Mar 22, 2024

The purpose of this PR is the last commit: Implementing system calls via an attribute proc macro to reduce the boilerplate code from having both sys_ and __sys_ functions everywhere.

Along the way, I found and resolved many issues and inconsistencies with the system calls.

This is best reviewed commit by commit.

Signed-off-by: Martin Kröning <[email protected]>
@mkroening mkroening force-pushed the system-macro branch 6 times, most recently from 6089d53 to 9bb6dbf Compare March 22, 2024 17:11
@mkroening mkroening force-pushed the system-macro branch 11 times, most recently from 6774fc5 to f4f4b05 Compare March 23, 2024 12:31
@mkroening mkroening self-assigned this Mar 23, 2024
@mkroening mkroening marked this pull request as ready for review March 23, 2024 12:56
@mkroening mkroening requested a review from stlankes March 23, 2024 12:56
@mkroening mkroening force-pushed the system-macro branch 2 times, most recently from cb14c4b to f9500d7 Compare March 23, 2024 13:03
Copy link
Contributor

@stlankes stlankes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@mkroening mkroening changed the title feat: add hermit-macro crate with system attribute feat: implement system calls with attribute proc macro Mar 23, 2024
@mkroening mkroening added this pull request to the merge queue Mar 23, 2024
Merged via the queue into hermit-os:main with commit 57ec4e1 Mar 23, 2024
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants