-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement system calls with attribute proc macro #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
mkroening
force-pushed
the
system-macro
branch
6 times, most recently
from
March 22, 2024 17:11
6089d53
to
9bb6dbf
Compare
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
mkroening
force-pushed
the
system-macro
branch
11 times, most recently
from
March 23, 2024 12:31
6774fc5
to
f4f4b05
Compare
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
Signed-off-by: Martin Kröning <[email protected]>
mkroening
force-pushed
the
system-macro
branch
2 times, most recently
from
March 23, 2024 13:03
cb14c4b
to
f9500d7
Compare
stlankes
approved these changes
Mar 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
mkroening
changed the title
feat: add hermit-macro crate with system attribute
feat: implement system calls with attribute proc macro
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is the last commit: Implementing system calls via an attribute proc macro to reduce the boilerplate code from having both
sys_
and__sys_
functions everywhere.Along the way, I found and resolved many issues and inconsistencies with the system calls.
This is best reviewed commit by commit.